CMake: Default color diagnostics to force-on with ccache/ninja #417
Conversation
There was a problem hiding this comment.
Diff looks good, in general I'm all for using the the facilities that cmake is providing.
Unfortunately it does not seem to detect the CI correctly and switches off color there.
E.g. compare main and this PR.
It should imo either default more aggressively to colored output or the -DCMAKE_COLOR_DIAGNOSTICS=ON flag would at least have to be added to the CI.
mattkretz
force-pushed
the
cmake_fix_compiler_color_usage
branch
from
1b0c2c6
to
c2b34f5
Compare
Reading diagnostics with ANSI color codes in between is unnecessarily hard. We now make use of the cmake documented switch to control color output. And we only force color on if the tooling suggest it might be necessary. Since GitHub Actions run without a terminal, auto-detection would always determine to not use colored output. However, color works fine on GitHub and therefore we force it on in CI builds. Signed-off-by: Matthias Kretz <m.kretz@gsi.de>
mattkretz
force-pushed
the
cmake_fix_compiler_color_usage
branch
from
c2b34f5
to
9833a6a
Compare
There was a problem hiding this comment.
Thanks for also changing the CI to keep the output colored there.
I also tested in my IDE (clion, with CCACHE and with -DUSE_CCACHE=OFF and gnumake to not run in the forced mode also in both building via the Build->BuildProjct menu and the builtin terminal) and it correctly used colored output everywhere.
I don't see negative side effects of this and form my PoV this could be merged.
Reading diagnostics with ANSI color codes in between is unnecessarily hard. We now make use of the cmake documented switch to control color output. And we only force color on if the tooling suggest it might be necessary.