Check if a port is connected or not #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amples. Signed-off-by: drslebedev <dr.s.lebedev@gmail.com>
drslebedev
force-pushed
the
is_connected
branch
from
34a089e
to
70d1a32
Compare
wirew0rm
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our implementation does not check whether a port is connected or if it is synchronous or asynchronous. We calculate the minimum number of processed samples across input and output ports, and only if both processedIn > 0 and processedOut > 0 do we forward tags.
This PR introduces a check to determine if a port is connected, which partially addresses the issue.
This PR helps to fix tag forwarding prolem for
Picoscopeblock.See #444 for more explanations.