refactor: Changed the behavior of batch-register #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Batch register now always registers a new minid by default. A new option, 'update_if_exists', is available to use an existing minid supplied in the `url` field if it is present, and update it instead of registering a brand new minid.
NickolausDS
commented
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch register now always registers a new Minid by default. A new
option, 'update_if_exists', is available to use an existing Minid
supplied in the
urlfield if it is present, and update it instead.This change resulted from discussion reviewing the bug report
here #75, and how this could result in undesirable behavior if
the checksums for given files were 'common' (for instance, if a
file was empty or contained content such as '1', this could return
another persons Minid).