fix: Xbox OS detection #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is better to detect Xbox devices as having the OS "Xbox". Otherwise, they are detected as "Windows 10", making it difficult to see the difference between Legacy Edge on Windows and the Xbox browser. (Karma (https://github.com/karma-runner/karma) only shows the browser & OS on the status line.) With this change, Xbox 360, Xbox One, Xbox X/S, and Xbox Series X/S are all detected as OS "Xbox" with version "360", "One", etc.
shaka-bot
pushed a commit
to shaka-project/shaka-player
that referenced
this pull request
Feb 10, 2021
This updates the UA parser to one that recognizes Xbox devices including Xbox One. Corresponds to PR faisalman/ua-parser-js#479 Change-Id: I5e92e78b06c981df1659f73264b6fabfc5eb56ac
|
Thank you! |
joeyparrish
added a commit
to shaka-project/shaka-player
that referenced
this pull request
Feb 25, 2021
This updates the UA parser to one that recognizes Xbox devices including Xbox One. Corresponds to PR faisalman/ua-parser-js#479 Change-Id: I5e92e78b06c981df1659f73264b6fabfc5eb56ac
joeyparrish
added a commit
to shaka-project/shaka-player
that referenced
this pull request
Mar 10, 2021
This updates the UA parser to one that recognizes Xbox devices including Xbox One. Corresponds to PR faisalman/ua-parser-js#479 Change-Id: I5e92e78b06c981df1659f73264b6fabfc5eb56ac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is better to detect Xbox devices as having the OS "Xbox".
Otherwise, they are detected as "Windows 10", making it difficult to
see the difference between Legacy Edge on Windows and the Xbox
browser. (Karma (https://github.com/karma-runner/karma) only shows
the browser & OS on the status line.)
With this change, Xbox 360, Xbox One, Xbox X/S, and Xbox Series X/S
are all detected as OS "Xbox" with version "360", "One", etc.