Sanitise fake email domain #53
Conversation
In order to more closely conform to RFC 1035 and actually generate valid fake emails, we only allow alphanumeric characters or hyphens in the text output. See: https://datatracker.ietf.org/doc/html/rfc1035#section-2.3.1 Resolves #52
|
Sorry, I haven't had time to come back to this, and now I can't see why CI failed because it's beyond the log retention period. I've sent an empty commit just to trigger CI. |
|
I have forked the main branch and updated the stack configuration so that now it supports the last three stable LTS Stack branches. I also noticed the random tests failures with countries in the test/AddressSpec.hs file. I have provided a commentary in the file with possible source of failures. The nightly branch is constantly failing because of dependencies. It is generally considered unstable. Can we omit it and think that the three last LTS branches are supported? |
Sounds good to me. |
|
So may I create a pull request to update the dependencies? |
|
The source of possible random failures in address can be occasionally deleted data-files from the fakedata.cabal in the previous commits. Now I added the data back and see no failures. |
Yes. |
|
@jezen The CI is fixed in the main branch, I think rebasing it will help. |
|
@Oleksandr-Zhabenko I will leave the decision to @jezen since he is the author of this PR. |
|
I'm happy for @Oleksandr-Zhabenko to take this work over from me. Thanks for checking! 🙂 |
|
Ok, I will take this for me. |
|
I have applied changes from the @jezen pull request and also provided additional check in the domain name for no underscores and the first mandatory letter. |
|
The following address has more extended email validation pattern. Is it better to use it? |
|
This one also uses some improvements. |
|
@Oleksandr-Zhabenko Nice! I would avoid using regex. I think the minimal check proposed by jezen is good enough. |
|
Should I make a fallback to the variant without introduced by me checking of underscores and hyphens? |
* Update stack.yaml * Update stack.yaml * Changed yaml files to use string-random-0.1.4.3 * Changed yaml files to use text-2.0.2 * Changed yaml files * Changed yaml files * Changed yaml files * Changed yaml files * Changed yaml files * Changed package.yaml file * Changed yaml files * Added stack-lts-2* yaml files * Changed workflow yaml file * Changed workflow yaml file * Changed workflow yaml file * Changed workflow yaml file * Changed stack.yaml file * Changed stack.yaml file * Changed stack.yaml file * Changed stack.yaml file * Added commentary to test/AddressSpec.hs about the reason of random tests failures * Added commentary to test/AddressSpec.hs about the reason of random tests failures * Changed stack.yaml * Added missed data-files in fakedata.cabal * Accepted changes proposed by psibi * Accepted changes proposed by psibi for stack.yaml * Accepted changes proposed by psibi for stack.yaml * Fixed .github/workflows/tests.yml * Added dist/cabal-config-flags to .gitignore file * Removed unneeded binary files * Removed formatting and the commentary * Sanitized fake email domain * Added hyphen into domain name checker in test/TextSpec.hs * Changed domain name checker in test/TextSpec.hs
|
Closing this in favour of #56. |
In order to more closely conform to RFC 1035 and actually generate valid fake emails, we only allow alphanumeric characters or hyphens in the text output.
See: https://datatracker.ietf.org/doc/html/rfc1035#section-2.3.1
Resolves #52