infra(vitest): no-alias-methods (#2899)

.eslintrc.cjs

@@ -191,6 +191,7 @@ module.exports = defineConfig({
         ],
 
         'vitest/expect-expect': 'off',
+        'vitest/no-alias-methods': 'error',
         'vitest/prefer-each': 'error',
         'vitest/prefer-to-have-length': 'error',
         'vitest/valid-expect': ['error', { maxArgs: 2 }],

test/modules/helpers-eval.spec.ts

@@ -4,13 +4,13 @@ import { fakeEval } from '../../src/modules/helpers/eval';
 
 describe('fakeEval()', () => {
   it('does not allow empty string input', () => {
-    expect(() => fakeEval('', faker)).toThrowError(
+    expect(() => fakeEval('', faker)).toThrow(
       new FakerError('Eval expression cannot be empty.')
     );
   });
 
   it('does not allow empty entrypoints', () => {
-    expect(() => fakeEval('foobar', faker, [])).toThrowError(
+    expect(() => fakeEval('foobar', faker, [])).toThrow(
       new FakerError('Eval entrypoints cannot be empty.')
     );
   });
@@ -116,7 +116,7 @@ describe('fakeEval()', () => {
   });
 
   it('requires a dot after a function call', () => {
-    expect(() => fakeEval('airline.airline()iataCode', faker)).toThrowError(
+    expect(() => fakeEval('airline.airline()iataCode', faker)).toThrow(
       new FakerError(
         "Expected dot ('.'), open parenthesis ('('), or nothing after function call but got 'i'"
       )
@@ -140,22 +140,22 @@ describe('fakeEval()', () => {
   });
 
   it('requires a valid expression (trailing dot)', () => {
-    expect(() => fakeEval('airline.airline.', faker)).toThrowError(
+    expect(() => fakeEval('airline.airline.', faker)).toThrow(
       new FakerError("Found dot without property name in 'airline.'")
     );
-    expect(() => fakeEval('airline.airline.()', faker)).toThrowError(
+    expect(() => fakeEval('airline.airline.()', faker)).toThrow(
       new FakerError("Found dot without property name in 'airline.()'")
     );
-    expect(() => fakeEval('airline.airline.().iataCode', faker)).toThrowError(
+    expect(() => fakeEval('airline.airline.().iataCode', faker)).toThrow(
       new FakerError("Found dot without property name in 'airline.().iataCode'")
     );
   });
 
   it('requires a valid expression (unclosed parenthesis)', () => {
-    expect(() => fakeEval('airline.airline(', faker)).toThrowError(
+    expect(() => fakeEval('airline.airline(', faker)).toThrow(
       new FakerError("Missing closing parenthesis in '('")
     );
-    expect(() => fakeEval('airline.airline(.iataCode', faker)).toThrowError(
+    expect(() => fakeEval('airline.airline(.iataCode', faker)).toThrow(
       new FakerError("Missing closing parenthesis in '(.iataCode'")
     );
   });