Skip to content

Commit

Permalink
build: add node v18 support
Browse files Browse the repository at this point in the history
  • Loading branch information
Shinigami92 committed May 3, 2022
1 parent a2da7c4 commit dd75642
Show file tree
Hide file tree
Showing 4 changed files with 61 additions and 49 deletions.
26 changes: 18 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,16 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node_version: [14, 16, 17]
node_version: [14, 16, 18]
include:
- os: macos-latest
node_version: 16
- os: macos-latest
node_version: 18
- os: windows-latest
node_version: 16
- os: windows-latest
node_version: 18
fail-fast: false

name: 'Build & Unit Test: node-${{ matrix.node_version }}, ${{ matrix.os }}'
Expand Down Expand Up @@ -49,7 +53,7 @@ jobs:

e2e-test:
runs-on: ubuntu-latest
name: 'E2E Doc Test: node-16, ubuntu-latest'
name: 'E2E Doc Test: node-18, ubuntu-latest'
steps:
- name: Checkout
uses: actions/checkout@v3
Expand All @@ -59,6 +63,12 @@ jobs:
with:
version: 6

- name: Set node version to 18
uses: actions/setup-node@v3
with:
node-version: 18
cache: 'pnpm'

- name: Install deps
run: pnpm install

Expand All @@ -67,7 +77,7 @@ jobs:

lint:
runs-on: ubuntu-latest
name: 'Lint: node-16, ubuntu-latest'
name: 'Lint: node-18, ubuntu-latest'
steps:
- name: Checkout
uses: actions/checkout@v3
Expand All @@ -79,10 +89,10 @@ jobs:
with:
version: 6

- name: Set node version to 16
- name: Set node version to 18
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
cache: 'pnpm'

- name: Install deps
Expand All @@ -98,7 +108,7 @@ jobs:

codecov:
runs-on: ubuntu-latest
name: 'Codecov: node-16, ubuntu-latest'
name: 'Codecov: node-18, ubuntu-latest'
steps:
- name: Checkout
uses: actions/checkout@v3
Expand All @@ -110,10 +120,10 @@ jobs:
with:
version: 6

- name: Set node version to 16
- name: Set node version to 18
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
cache: 'pnpm'

- name: Install deps
Expand Down
2 changes: 1 addition & 1 deletion netlify.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[build.environment]
NODE_VERSION = "16"
NODE_VERSION = "18"
NPM_FLAGS = "--version" # prevent Netlify npm install

# Documentation
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
},
"devDependencies": {
"@types/markdown-it": "~12.2.3",
"@types/node": "~16.11.33",
"@types/node": "~17.0.31",
"@types/prettier": "~2.6.0",
"@types/sanitize-html": "~2.6.2",
"@types/validator": "~13.7.2",
Expand Down
80 changes: 41 additions & 39 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit dd75642

Please sign in to comment.