Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banner to next.fakerjs.dev #1456

Closed
ST-DDT opened this issue Oct 15, 2022 · 1 comment · Fixed by #1487
Closed

Add banner to next.fakerjs.dev #1456

ST-DDT opened this issue Oct 15, 2022 · 1 comment · Fixed by #1487
Labels
c: docs Improvements or additions to documentation help wanted Extra attention is needed p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Oct 15, 2022

Clear and concise description of the problem

Currently is it hard to spot whether you are on a production branch or our development branch.

Alternatively

Suggested solution

Show a banner with a hint that the users is currently viewing the development branch.

It might be useful to always show the banner if the hostname is not fakerjs.dev.

The banner should contain a link to the production website (https://fakerjs.dev).

Alternative

No response

Additional context

This originally came up here: #1438 (comment)

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation help wanted Extra attention is needed p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Oct 15, 2022
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Oct 15, 2022
@Shinigami92 Shinigami92 moved this to Todo in Faker Roadmap Oct 15, 2022
@Shinigami92
Copy link
Member

@brc-dd told me we can use layout-top https://vitepress.vuejs.org/guide/theme-introduction#layout-slots for that 👍
I can tackle this, if no one else is interested in this. But first I would like to get some other of my PRs in a review-able state or even merged, so I don't have too many branches open from my site.

@brc-dd brc-dd mentioned this issue Oct 25, 2022
1 task
Repository owner moved this from Todo to Done in Faker Roadmap Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation help wanted Extra attention is needed p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants