-
-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add version banner #1487
docs: add version banner #1487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The banner should always be shown on non-https://fakerjs.dev/
sites
But they all have the same source, so we need to check window.location.host !== 'fakerjs.dev'
or something like that
This is ready for review guys! 🙏 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1487 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 2165 2165
Lines 237147 237147
Branches 1021 1021
=======================================
Hits 236285 236285
Misses 841 841
Partials 21 21 |
I'm thinking about to use the |
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Co-authored-by: Shinigami <chrissi92@hotmail.de>
EDIT: Nevermind. I closed it like 23h ago... |
fix faker-js#1497 backport faker-js#1487
fixes #1456
TODO:
Note on howid
works: Each time you change the banner text and want users (those who had dismissed it) to see new banner just update the id to any new random value. You can omitid
to for a particular channel to don't persist users' preference for banner dismissal.Updated behavior: Dismissal preference is only kept for 24hrs now. There won't be need to add random ids.