Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commit-convention.md #190

Closed
mbokinala opened this issue Jan 17, 2022 · 3 comments · Fixed by #204
Closed

Add commit-convention.md #190

mbokinala opened this issue Jan 17, 2022 · 3 comments · Fixed by #204
Labels
c: docs Improvements or additions to documentation c: feature Request for new feature good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mbokinala
Copy link
Contributor

mbokinala commented Jan 17, 2022

Currently, when attempting to commit with a message that does not follow the proper format enforced by scripts/verifyCommit.ts, the following error message is shown:

 ERROR  invalid commit message format.

  Proper commit message format is required for automated changelog generation. Examples:

    feat: add 'comments' option
    fix: handle events on blur (close #28)

  See .github/commit-convention.md for more details.

However, the file .github/commit-convention.md does not exist, so contributors must track down the verifyCommit script by looking at package.json to find the format/types for commit messages (like feat, fix, docs, dx, refactor, perf, test, etc).

An alternative to adding the file would be to describe the proper commit message convention in the error message itself and provide all the various options for the 'type' of the commit (feat, fix, etc). All the allowed types can be found in /scripts/verifyCommit.ts

@mbokinala mbokinala added the s: pending triage Pending Triage label Jan 17, 2022
@Shinigami92 Shinigami92 added c: docs Improvements or additions to documentation c: feature Request for new feature good first issue Good for newcomers help wanted Extra attention is needed labels Jan 17, 2022
@github-actions
Copy link
Contributor

Hello @mbokinala. We like your proposal/feedback and would appreciate a contribution via a Pull Request by you or another community member. We thank you in advance for your contribution and are looking forward to reviewing it!

@github-actions github-actions bot removed the s: pending triage Pending Triage label Jan 17, 2022
@Shinigami92
Copy link
Member

Shinigami92 commented Jan 17, 2022

We took the script from Vite.
Thanks for the hint 🙂
Are you willing to open a PR for this?

PS: I'm a core team member of Vite 😉 You are allowed to copy the file over.

@mbokinala
Copy link
Contributor Author

Sure, will do

mbokinala added a commit to mbokinala/faker that referenced this issue Jan 17, 2022
taken from vitejs/vite

closes faker-js#190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation c: feature Request for new feature good first issue Good for newcomers help wanted Extra attention is needed
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants