Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate phone.phoneFormat #694

Closed
xDivisionByZerox opened this issue Mar 27, 2022 · 2 comments · Fixed by #958
Closed

deprecate phone.phoneFormat #694

xDivisionByZerox opened this issue Mar 27, 2022 · 2 comments · Fixed by #958
Assignees
@ST-DDT
Labels
p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
v7.0 - Structural...

Comments

@xDivisionByZerox
Copy link
Member

xDivisionByZerox commented Mar 27, 2022 •
edited
Loading

Clear and concise description of the problem

Phone formats should not be exposed directly.

Suggested solution

Deprecate phone.phoneFormat in favor of phone.phoneNumber.

Alternative

No response

Additional context

Marked as TODO in #541
@xDivisionByZerox xDivisionByZerox added good first issue Good for newcomers p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Mar 27, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Mar 27, 2022

IMO we should not expose the format directly.

@xDivisionByZerox
Copy link
Member Author

I agree with you on that (if you really need to access them you could simply faker.definitions.phone_number.formats). Should I rephrase this issue to remove the util functions that expose phone formats and mark for discussion?

@xDivisionByZerox xDivisionByZerox added s: awaiting more info Additional information are requested and removed good first issue Good for newcomers s: accepted Accepted feature / Confirmed bug labels Mar 27, 2022
@xDivisionByZerox xDivisionByZerox self-assigned this Mar 27, 2022
This was referenced Mar 28, 2022
Closed
Closed
@ST-DDT ST-DDT linked a pull request Mar 28, 2022 that will close this issue
chore: rename phone.phoneFormats() to formats() #710
Closed
This was referenced Mar 29, 2022
Closed
Closed
@xDivisionByZerox xDivisionByZerox removed their assignment Mar 29, 2022
@xDivisionByZerox xDivisionByZerox linked a pull request Mar 29, 2022 that will close this issue
fix: Updated src/phone.ts #724
Closed
@ST-DDT ST-DDT mentioned this issue May 15, 2022
Merged
@ST-DDT ST-DDT linked a pull request May 15, 2022 that will close this issue
chore: deprecate phone.phoneFormats #958
Merged
@ST-DDT ST-DDT self-assigned this May 15, 2022
@xDivisionByZerox xDivisionByZerox changed the title rename phone.phoneFormat to phone.format deprecate phone.phoneFormat May 17, 2022
@xDivisionByZerox xDivisionByZerox added s: accepted Accepted feature / Confirmed bug and removed s: awaiting more info Additional information are requested labels May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ST-DDT ST-DDT

Labels
p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7.0 - Structural Breaking Changes
3 participants
@ST-DDT @Shinigami92 @xDivisionByZerox