chore: change some phone methods #722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed phoneFormats () to formats() and PhoneNumber() to number() Removed todos changed warnings
Shinigami92
requested changes
Mar 29, 2022
| */ | ||
| // TODO @pkuczynski 2022-02-01: simplify name to `format()` | ||
| phoneFormats(): string { |
There was a problem hiding this comment.
We should add aliases for these and call the deprecation function, so migrations are more smooth
import-brain
added
p: 1-normal
import-brain
added
c: chore
|
Superseded by #724 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed
phoneFormats ()toformats()andPhoneNumber()tonumber()Ref : #694
#693