Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename phone.phoneNumber to phone.number #693

Closed
xDivisionByZerox opened this issue Mar 27, 2022 · 4 comments
Closed

rename phone.phoneNumber to phone.number #693

xDivisionByZerox opened this issue Mar 27, 2022 · 4 comments
Assignees
Labels
good first issue Good for newcomers m: phone Something is referring to the phone module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug

Comments

@xDivisionByZerox
Copy link
Member

xDivisionByZerox commented Mar 27, 2022

Clear and concise description of the problem

Function name is repeating the module name.

Suggested solution

Create a new function number in the phone module that is a copy of the current phoneNumber function. Call this new function in the current function and add a deprecation warning.

Alternative

No response

Additional context

Marked as todo in #541

@xDivisionByZerox xDivisionByZerox added s: pending triage Pending Triage good first issue Good for newcomers s: accepted Accepted feature / Confirmed bug and removed s: pending triage Pending Triage labels Mar 27, 2022
@xDivisionByZerox xDivisionByZerox added the p: 1-normal Nothing urgent label Mar 27, 2022
@import-brain
Copy link
Member

How would we go about this? Would we simply rename all instances of phone.phoneNumber() to phone.number()? Or should we keep phone.phoneNumber() and add a deprecation warning saying to use the new phone.number() function which will be a copy paste of phone.phoneNumber().

@Shinigami92
Copy link
Member

wait on #689, then yes, add deprecation warning + alias

@xDivisionByZerox
Copy link
Member Author

And remove completely in v7?

@xDivisionByZerox
Copy link
Member Author

This was resolved in #1063.

@xDivisionByZerox xDivisionByZerox self-assigned this Jul 30, 2022
@xDivisionByZerox xDivisionByZerox added the m: phone Something is referring to the phone module label Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers m: phone Something is referring to the phone module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
3 participants