-
-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use a standardized deprecated function #689
chore: use a standardized deprecated function #689
Conversation
Codecov Report
@@ Coverage Diff @@
## main #689 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 1923 1924 +1
Lines 176900 176989 +89
Branches 901 904 +3
=======================================
+ Hits 175739 175828 +89
Misses 1105 1105
Partials 56 56
|
Before I update the tests, @pkuczynski could you have a new look? |
Except for the single comment I left, it all looks good to me! :) Still think annotation would work better ;) |
Co-authored-by: Piotr Kuczynski <pkuczynski@users.noreply.github.com>
IMO we should always include the |
closes #645