Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use a standardized deprecated function #689

Merged
merged 16 commits into from
Mar 28, 2022

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Mar 26, 2022

closes #645

@Shinigami92 Shinigami92 added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Mar 26, 2022
@Shinigami92 Shinigami92 added this to the v6.1 - First bugfixes milestone Mar 26, 2022
@Shinigami92 Shinigami92 self-assigned this Mar 26, 2022
@codecov
Copy link

codecov bot commented Mar 26, 2022

Codecov Report

Merging #689 (cfb39c4) into main (94c96ba) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head cfb39c4 differs from pull request most recent head 8e4c4f3. Consider uploading reports for the commit 8e4c4f3 to get more accurate results

@@           Coverage Diff           @@
##             main     #689   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files        1923     1924    +1     
  Lines      176900   176989   +89     
  Branches      901      904    +3     
=======================================
+ Hits       175739   175828   +89     
  Misses       1105     1105           
  Partials       56       56           
Impacted Files Coverage Δ
src/helpers.ts 99.14% <100.00%> (+0.01%) ⬆️
src/internal/deprecated.ts 100.00% <100.00%> (ø)
src/name.ts 99.71% <100.00%> (+0.02%) ⬆️
src/random.ts 99.46% <100.00%> (+0.01%) ⬆️
src/time.ts 100.00% <100.00%> (ø)

@Shinigami92 Shinigami92 marked this pull request as ready for review March 26, 2022 21:11
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 26, 2022 21:11
@Shinigami92 Shinigami92 requested a review from a team March 26, 2022 21:11
src/deprecated.ts Outdated Show resolved Hide resolved
src/deprecated.ts Outdated Show resolved Hide resolved
src/deprecated.ts Outdated Show resolved Hide resolved
src/helpers.ts Outdated Show resolved Hide resolved
src/name.ts Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 marked this pull request as draft March 27, 2022 10:51
@Shinigami92
Copy link
Member Author

Before I update the tests, @pkuczynski could you have a new look?

src/deprecated.ts Outdated Show resolved Hide resolved
@pkuczynski
Copy link
Member

Before I update the tests, @pkuczynski could you have a new look?

Except for the single comment I left, it all looks good to me! :) Still think annotation would work better ;)

Co-authored-by:
Piotr Kuczynski <pkuczynski@users.noreply.github.com>
@Shinigami92 Shinigami92 marked this pull request as ready for review March 28, 2022 12:36
@Shinigami92 Shinigami92 requested a review from a team March 28, 2022 12:37
@ST-DDT
Copy link
Member

ST-DDT commented Mar 28, 2022

IMO we should always include the () in the message to make it easier to see that it refers to a method call

@ST-DDT ST-DDT mentioned this pull request Mar 28, 2022
@ST-DDT ST-DDT requested review from a team March 28, 2022 17:15
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 28, 2022 17:16
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 28, 2022 17:18
@Shinigami92 Shinigami92 merged commit 8ab5eff into main Mar 28, 2022
@Shinigami92 Shinigami92 deleted the refactor-standardized-deprecation-function branch March 28, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants