Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename phone.phoneNumber() to number() #712

Closed
wants to merge 2 commits into from
Closed

chore: rename phone.phoneNumber() to number() #712

wants to merge 2 commits into from

Conversation

kumar-kalyan
Copy link

  • Renamed phoneNumber() to number()
  • changed deprecation warning

Ref : #693

@kumar-kalyan
Renamed phoneNumber() & changed deprecation warning
4dc58b4 
Renamed  phoneNumber() to number()
@kumar-kalyan kumar-kalyan requested a review from a team as a code owner March 28, 2022 20:06
ST-DDT
ST-DDT requested changes Mar 28, 2022
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also have to update the tests.

src/phone.ts
* faker.phone.phoneNumber('+48 91 ### ## ##') // '+48 91 463 61 70'
* faker.phone.number() // '961-770-7727'
* faker.phone.number('501-###-###') // '501-039-841'
* faker.phone.number('+48 91 ### ## ##') // '+48 91 463 61 70'
*/
// TODO @pkuczynski 2022-02-01: simplify name to `number()`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember to remove this comment.

ST-DDT
ST-DDT reviewed Mar 28, 2022
View reviewed changes
src/phone.ts Show resolved Hide resolved
@ST-DDT ST-DDT added this to the v6.2 - New small features milestone Mar 28, 2022
@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Mar 28, 2022
@ST-DDT ST-DDT linked an issue Mar 28, 2022 that may be closed by this pull request
rename phone.phoneNumber to phone.number #693
Closed
@ST-DDT ST-DDT changed the title Renamed phoneNumber() & changed deprecation warning chore: rename phone.phoneNumber() to number() Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT requested changes

Assignees

@kumar-kalyan kumar-kalyan

Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v6.2 - New small features
Development

Successfully merging this pull request may close these issues.

rename phone.phoneNumber to phone.number
2 participants
@kumar-kalyan @ST-DDT