chore: deprecate address.streetPrefix and suffix

[ST-DDT]

The street prefix and suffix methods only generate parts of the data and not all of the locales support these.
IMO the methods aren't useful by themselves and thus should be removed.

[codecov]

Codecov Report

Merging #1053 (81de721) into main (a65f1a2) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 81de721 differs from pull request most recent head db356d0. Consider uploading reports for the commit db356d0 to get more accurate results

@@            Coverage Diff             @@
##             main    #1053      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files        2153     2153              
  Lines      236493   236512      +19     
  Branches      976      975       -1     
==========================================
+ Hits       235605   235621      +16     
- Misses        867      870       +3     
  Partials       21       21              

Impacted Files	Coverage Δ
src/modules/random/index.ts	98.13% <ø> (-0.01%)	⬇️
src/locales/af_ZA/address/street.ts	100.00% <100.00%> (ø)
src/locales/de_CH/address/street.ts	100.00% <100.00%> (ø)
src/locales/el/address/street.ts	100.00% <100.00%> (ø)
src/locales/en_AU/address/street.ts	100.00% <100.00%> (ø)
src/locales/en_CA/address/street.ts	100.00% <100.00%> (ø)
src/locales/en_GB/address/street.ts	100.00% <100.00%> (ø)
src/locales/en_IE/address/street.ts	100.00% <100.00%> (ø)
src/locales/en_IND/address/street.ts	100.00% <100.00%> (ø)
src/locales/en_NG/address/street.ts	100.00% <100.00%> (ø)
... and 9 more

[xDivisionByZerox]

IMO either keep them as util functions (for custom tooling) or remove them completely, like don't advertise the usage with faker.fake(). Doesn't make sense to me to tell the user "hey can still use this, but not as nice as it was for now" (write a "complex" non-typesafe string).

[ST-DDT]

IMO either keep them as util functions (for custom tooling) or remove them completely, like don't advertise the usage with faker.fake().

I do want to remove them, but I want to give everyone a chance to migrate.
I could switch to faker.helpers.arrayElement(faker.definitions.address.street_prefix), but that is way longer.
The current usages of these methods are mostly limited to faker.fake(), so thats why I have chosen that one.

[xDivisionByZerox]

I do want to remove them, but I want to give everyone a chance to migrate.
I could switch to faker.helpers.arrayElement(faker.definitions.address.street_prefix), but that is way longer.
The current usages of these methods are mostly limited to faker.fake(), so thats why I have chosen that one.

Nah, I think you misunderstood me. If we deprecate these functions, why leave the definitions?

[ST-DDT]

If we deprecate these functions, why leave the definitions?

To give users a hint how they should structure their definitions to be compatible with our format/our existing locales.
If possible I still want all locales to have the same set of used files.
But there might be other/better ways to achieve that (e.g. a file-name whitelist, so it's easier to tell when a file is added that doesn't match our existing files).

[Shinigami92]

IMO it is okay to remove / hide this from the end-user as I would not know what a street suffix/prefix would even be 🤷
We also didn't explain it anywhere but just provide it
In the end Faker should be a tool to generate meaningful data, and streetnames are totally okay, but what is a street prefix/suffix?