chore(user-agent): fix linter warnings

[xDivisionByZerox]

This PR fixes all remaining linter warnings in user-agent.ts.

To achieve this I changed the implementation of the function in a non-breaking way. I mainly simplified the rnd function since it had a lot of unnecessary branches. I also converted all internal functions to constants so they don't require any JSDoc.

[xDivisionByZerox]

BTW, this PR brings the total number of linter warnings in the project down to ZERO 🚀

[codecov]

Codecov Report

Merging #1174 (a399b84) into main (02ead05) will decrease coverage by 0.00%.
The diff coverage is 77.68%.

@@            Coverage Diff             @@
##             main    #1174      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.01%     
==========================================
  Files        2152     2152              
  Lines      236201   236234      +33     
  Branches      980      974       -6     
==========================================
+ Hits       235336   235347      +11     
- Misses        844      866      +22     
  Partials       21       21              

Impacted Files	Coverage Δ
src/modules/internet/user-agent.ts	81.74% <77.68%> (-4.64%)	⬇️

[xDivisionByZerox]

I can't reproduce the error described in the failing pipeline. Anyone may help?

[ST-DDT]

I can't reproduce the error described in the failing pipeline. Anyone may help?

This is a relatively new error that only happens randomly.
I only managed to reproduce it once or twice locally, but I don't know what's causing this.
We could increase the timeout for that test, but I'm not sure whether that's the actual issue or whether the imports in there examples get resolved strangely and thus appear to hang for a "short" moment. (Thus it always happens in a different test with many imports).
This might or might not be related to the long test start times that a few users have reported which we then recommended to use the locale specific faker instance.

I ran the test again and now it is working.

[xDivisionByZerox]

This might or might not be related to the long test start times that a few users have reported which we then recommended to use the locale specific faker instance.

I see. Can this be due to all modules importing Faker from the src/index.ts file and creating a circular reference in the process (ModuleX => importing Faker from index.ts => index.ts import ModuleX)? This is just a guess, I have no idea how dependency resolution works in JS.

[xDivisionByZerox]

@ST-DDT the accepted label is described for accepted features or confirmed bugs. Not for chores 🤔