-
-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: turn on noImplicitThis #1842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As already discussed in Discord, but to transparently ask this here again:
Does this still work with something like
class X {
y = 1
a() {
return this.y
}
}
const x = new X()
unqiue(x.a) // is y still bound to the class instance?
In v7.6 and next it outputs undefined. Neither is correct. FFR: In v7.6 and next FWIW Both variants work when using |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1842 +/- ##
==========================================
- Coverage 99.63% 99.62% -0.02%
==========================================
Files 2346 2346
Lines 236489 236489
Branches 1148 1141 -7
==========================================
- Hits 235633 235600 -33
- Misses 834 867 +33
Partials 22 22
|
Fixes
#1835, #1838Turn on strictBindCallApply in tsconfig #1835Both rules need to be changed at the same time, because they cannot be fixed individually.