chore: add support for readonly arrays #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for vigilant-wescoff-04e480 ready! 🔨 Explore the source changes: 62d934b 🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61e83964196a7e00071a65a2 😎 Browse the preview: https://deploy-preview-189--vigilant-wescoff-04e480.netlify.app |
|
Is this just enough? I expected something like |
Shinigami92
approved these changes
Jan 17, 2022
There was a problem hiding this comment.
I tested a bit in TS Playground and everything works find 👍
damienwebdev
requested changes
Jan 18, 2022
import-brain
approved these changes
Jan 19, 2022
pkuczynski
pushed a commit
to pkuczynski/faker
that referenced
this pull request
Jan 21, 2022
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Revisit to add TS tests once this PR (https://github.com/faker-js/faker/pull/186/files) is merged.
I searched for all parameters that have
T[]and don't modify the array.