test(docs): disable versions check for external contributors

[ST-DDT]

Fixes #2174 (comment)

This disables the versions check for external contributors/those that do not use the faker main repository as their origin.

[codecov]

Codecov Report

Merging #2181 (acb34a7) into next (ef6334c) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #2181   +/-   ##
=======================================
  Coverage   99.60%   99.61%           
=======================================
  Files        2800     2800           
  Lines      252410   252410           
  Branches     1097     1099    +2     
=======================================
+ Hits       251421   251441   +20     
+ Misses        962      942   -20     
  Partials       27       27           

see 2 files with indirect coverage changes

[ST-DDT]

Result if origin != faker main repo:

Result if origin = faker main repo:

[Shinigami92]

Will the CI still check the docs version, even when the PR is on another fork?

[ST-DDT]

Will the CI still check the docs version, even when the PR is on another fork?

Good point. I have to check.

[Shinigami92]

I could be wrong, but it seems that this PR disables the test when a contributor creates a PR in their own fork. But when we then merge that PR, the test would run on our next branch and could then fail.

So this doesn't look like it is the right solution, but sadly I also do not have another idea right now 😕

[Shinigami92]

Is the test in our CI always executed via a PR and therefore the origin will always be faker-js/faker?
Or does the CI origin run on the fork?

[ST-DDT]

I created #2394 as an external contributor test.

• test(docs): disable versions check for external contributors (external) #2394

[Shinigami92]

Yes, the test gets executed: https://github.com/faker-js/faker/actions/runs/6201950881/job/16839680435?pr=2394#step:8:110

[ST-DDT]

From #2394 :

https://github.com/faker-js/faker/actions/runs/6201950881/job/16839679994?pr=2394#step:2:39

git remote add origin https://github.com/faker-js/faker

https://github.com/faker-js/faker/actions/runs/6201950881/job/16839679994?pr=2394#step:8:108

stdout | unknown test
https://github.com/faker-js/faker

✓ test/docs/versions.spec.ts (1 test) 6ms

It uses the remote of the target repository as origin.