feat(image): add image dataUri with base64

[ghost]

Adds a image type parameter type to faker.image.dataUri.

If type equals 'svg', it returns a URI that contains a svg image as before.
If type equals 'base64', it returns a URI that contains a base64 image as described in #1550.

Currently the base64 image is generated by converting a svg image. I am not sure, if that is an issue. As @matthewmayer pointed out in the issue, it would probably bloat the code if it should also return a base64 encoded jpg or png.

Additionally I added a few tests for the new parameter similar to the ones that already existed.

Closes #1550.

[codecov]

Codecov Report

Merging #2273 (a4bd63c) into next (f71cc1c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #2273      +/-   ##
==========================================
- Coverage   99.61%   99.60%   -0.01%     
==========================================
  Files        2774     2774              
  Lines      251763   251780      +17     
  Branches     1083     1082       -1     
==========================================
+ Hits       250783   250788       +5     
- Misses        953      965      +12     
  Partials       27       27              

Files Changed	Coverage Δ
src/modules/image/index.ts	100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

[ST-DDT]

There seems to be merge conflicts. Could you please fix them?

[ghost]

Sorry for the late reply. I fixed the merge conflicts.

[xDivisionByZerox]

Team decision:

We accept this feature. This can now be reviewed.

[ST-DDT]

I just noticed, that dataUri doesn't have seeded tests, so I created a PR for that.

Blocked by:

• test(image): add seeded tests for dataUri #2317

[ST-DDT]

We added some (forgotten) seeded tests to ensure the values generated by this method are reproducible.
Please extend them to include the type option.

faker/test/modules/image.spec.ts

Lines 71 to 82 in b468d5f

	t.describe('dataUri', (t) => {
	t.it('noArgs')
	.it('with width', { width: 128 })
	.it('with height', { height: 128 })
	.it('with width and height', { width: 128, height: 128 })
	.it('with color', { color: 'blue' })
	.it('with all options', {
	width: 128,
	height: 128,
	color: 'blue',
	});
	});

[ST-DDT]

Sorry, for all the back and forth.

Stale