ci: use node 20 #2398
Merged
ci: use node 20 #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2398 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 2800 2800
Lines 252410 252410
Branches 1100 1098 -2
=======================================
Hits 251432 251432
Misses 951 951
Partials 27 27 |
|
This comment actions/runner#2033 (comment) potentially saved me multiple hours of debugging ❤️ |
|
This might solve the issue: |
This comment is a year old, I think the current solution is sufficient enough |
Shinigami92
commented
Sep 17, 2023
| container: cypress/browsers:node18.12.0-chrome107 | ||
| container: | ||
| image: cypress/browsers:node-20.6.1-chrome-116.0.5845.187-1-ff-117.0-edge-116.0.1938.76-1 | ||
| options: --user 1001 |
There was a problem hiding this comment.
I'm confused 🤔
This was literally the solution to the problem, now with that it works
|
Sorry async communication error. |
Shinigami92
requested review from
ST-DDT,
prisis,
xDivisionByZerox and
a team
|
I will switch the CI requirements, when the PR gets the required approval amount to get merged |
ST-DDT
approved these changes
Sep 17, 2023
xDivisionByZerox
approved these changes
Sep 17, 2023
prisis
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the current node version
Look if it speeds up the CI by a little bit
Rough comparison: around 3min FASTER 🚀