docs: fix bad Promise usage #2475
Merged
+59
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: bug
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2475 +/- ##
==========================================
- Coverage 99.59% 99.58% -0.01%
==========================================
Files 2823 2823
Lines 255516 255516
Branches 1105 1104 -1
==========================================
- Hits 254474 254466 -8
- Misses 1014 1022 +8
Partials 28 28 |
xDivisionByZerox
approved these changes
Oct 13, 2023
import-brain
approved these changes
Oct 14, 2023
matthewmayer
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two locations that incorrectly deal with Promises.
scripts/apidoc/generate.ts-> Minor miss-usage / no problemsscripts/apidoc/signature.ts->Record<[object Promise], [object Promise]>Screenshot
https://next.fakerjs.dev/api/helpers.html#mustache
I couldn't find which lint rule could be used to prevent this in the future 😿 .