-
-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra(deps): switch to commit-and-tag-version #2882
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2882 +/- ##
========================================
Coverage 99.96% 99.96%
========================================
Files 2977 2977
Lines 215466 215466
Branches 950 601 -349
========================================
+ Hits 215387 215395 +8
+ Misses 79 71 -8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
We already had a config file for standard version: https://github.com/faker-js/faker/blob/043f68b0691f1cc1c11f2257b9c9e2cfa5047c72/.versionrc.json |
It doesn't show up in the config spec, but seems to work anyway. |
It's not obvious but as they state in their README:
In combination with the point aboth:
|
Replaces the
standard-version
dependency with the maintained forkcommit-and-tag-version
.I did some tests locally and release seems to behave the exact same as
standard-version
, but you might want to try it out yourself.I also explicitly disabled the tag generation, as we generate the tags via GH releases anyway.