Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(release): check release PR #2988

Merged
merged 7 commits into from
Jul 7, 2024
Merged

infra(release): check release PR #2988

merged 7 commits into from
Jul 7, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jul 1, 2024

This implements the second step of our automated release pipeline.

Tasks:

  • Checkout faker
  • Checkout playground
  • Install pnpm
  • Setup node
  • Install deps - faker
  • Build - faker
  • Install deps - playground
  • Build - playground
  • Test - playground

Demo PRs:


Automated Release Pipeline PRs:

  1. infra(release): prepare release PR #2981
  2. infra(release): check release PR #2988
  3. infra(release): draft release #2990
  4. infra(release): publish release #2991

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Jul 1, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Jul 1, 2024
@ST-DDT ST-DDT requested review from a team July 1, 2024 10:48
@ST-DDT ST-DDT self-assigned this Jul 1, 2024
Copy link

netlify bot commented Jul 1, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit a1a5a68
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66848681fe51120008045b0f
😎 Deploy Preview https://deploy-preview-2988.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (f104dd5) to head (a1a5a68).

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #2988    +/-   ##
========================================
  Coverage   99.96%   99.96%            
========================================
  Files        2747     2747            
  Lines      239079   239079            
  Branches      591      944   +353     
========================================
+ Hits       238999   239000     +1     
+ Misses         80       79     -1     

see 1 file with indirect coverage changes

@ST-DDT ST-DDT requested review from xDivisionByZerox and a team July 2, 2024 20:10
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would potentially have some questions, but I think I can approve it for now

e.g.:

  • should we think about to always run this check? I mean for any PR 🤔
  • why should it only run on modified changelog.md

@ST-DDT
Copy link
Member Author

ST-DDT commented Jul 3, 2024

  • should we think about to always run this check? I mean for any PR 🤔

We could do that but it has a side effect, that all features that are used in the playground that might experience breaking changes need to be updated to the new feature before it is available as a dependency. This is also the case for the releasenPR but that those are even rarer.
In the end it doesnt matter.

@ST-DDT
Copy link
Member Author

ST-DDT commented Jul 3, 2024

  • why should it only run on modified changelog.md

There is no filter for release branches and that file is the best indicator for a release branch afaict.

@ST-DDT ST-DDT merged commit 392d26e into next Jul 7, 2024
25 checks passed
@ST-DDT ST-DDT deleted the infra/release/ci branch July 7, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants