-
-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra(release): check release PR #2988
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2988 +/- ##
========================================
Coverage 99.96% 99.96%
========================================
Files 2747 2747
Lines 239079 239079
Branches 591 944 +353
========================================
+ Hits 238999 239000 +1
+ Misses 80 79 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would potentially have some questions, but I think I can approve it for now
e.g.:
- should we think about to always run this check? I mean for any PR 🤔
- why should it only run on modified changelog.md
We could do that but it has a side effect, that all features that are used in the playground that might experience breaking changes need to be updated to the new feature before it is available as a dependency. This is also the case for the releasenPR but that those are even rarer. |
There is no filter for release branches and that file is the best indicator for a release branch afaict. |
This implements the second step of our automated release pipeline.
Tasks:
Demo PRs:
Automated Release Pipeline PRs: