Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: remove redirect from current stable #3091

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Sep 5, 2024

Removes the redirect from v9.fakerjs.dev -> fakerjs.dev

  • This makes it easier to create permanent links to our documentation
  • This fixes the broken search index for v9 (when merged/pushed to the v9 branch).

@ST-DDT ST-DDT added c: bug Something isn't working c: docs Improvements or additions to documentation p: 2-high Fix main branch c: infra Changes to our infrastructure or project setup labels Sep 5, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Sep 5, 2024
@ST-DDT ST-DDT requested review from a team September 5, 2024 23:15
@ST-DDT ST-DDT self-assigned this Sep 5, 2024
Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 4ad8685
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66df5e183ef2fc0009dd5c63
😎 Deploy Preview https://deploy-preview-3091.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (200beb9) to head (4ad8685).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3091      +/-   ##
==========================================
- Coverage   99.97%   99.96%   -0.01%     
==========================================
  Files        2776     2776              
  Lines      226260   226260              
  Branches      942      942              
==========================================
- Hits       226194   226192       -2     
- Misses         66       68       +2     

see 2 files with indirect coverage changes

@ST-DDT ST-DDT modified the milestones: vAnytime, v9.0 Sep 5, 2024
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval in trust, we can fix/revert if something breaks

@ST-DDT ST-DDT enabled auto-merge (squash) September 9, 2024 20:44
@ST-DDT ST-DDT merged commit 533c131 into next Sep 9, 2024
23 checks passed
@ST-DDT ST-DDT deleted the infra/netlify/redirects branch September 9, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working c: docs Improvements or additions to documentation c: infra Changes to our infrastructure or project setup p: 2-high Fix main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants