Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix all_functional tests #609

Merged
merged 6 commits into from
Mar 28, 2022
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 10, 2022

The all_functional.spec.ts doesn't work as expected. We need to fix this eventually.
This conceals 20 errors:

 FAIL  test/all_functional.spec.ts > functional tests > az > address > state()
 FAIL  test/all_functional.spec.ts > functional tests > az > company > companySuffix()
 FAIL  test/all_functional.spec.ts > functional tests > az > name > prefix()
 FAIL  test/all_functional.spec.ts > functional tests > az > name > suffix()
 FAIL  test/all_functional.spec.ts > functional tests > cz > address > state()
 FAIL  test/all_functional.spec.ts > functional tests > cz > address > stateAbbr()
 FAIL  test/all_functional.spec.ts > functional tests > id_ID > name > prefix()
 FAIL  test/all_functional.spec.ts > functional tests > it > name > suffix()
 FAIL  test/all_functional.spec.ts > functional tests > mk > name > suffix()
 FAIL  test/all_functional.spec.ts > functional tests > pt_BR > address > cityPrefix()
 FAIL  test/all_functional.spec.ts > functional tests > pt_PT > address > cityPrefix()
 FAIL  test/all_functional.spec.ts > functional tests > pt_PT > address > citySuffix()
 FAIL  test/all_functional.spec.ts > functional tests > pt_PT > name > suffix()
 FAIL  test/all_functional.spec.ts > functional tests > ru > name > prefix()
 FAIL  test/all_functional.spec.ts > functional tests > ru > name > suffix()
 FAIL  test/all_functional.spec.ts > functional tests > sk > address > state()
 FAIL  test/all_functional.spec.ts > functional tests > sk > address > stateAbbr()
AssertionError: expected undefined to be truthy
 ❯ test/all_functional.spec.ts:78:31
 FAIL  test/all_functional.spec.ts > functional tests > he > address > countryCode()
 FAIL  test/all_functional.spec.ts > functional tests > nb_NO > address > state()
AssertionError: expected '' to be truthy
 ❯ test/all_functional.spec.ts:78:31
 FAIL  test/all_functional.spec.ts > functional tests > nb_NO > random > words()
Error: string parameter is required!
 ❯ Fake.fake src/fake.ts:51:12

We have to check how we fix these issues.
Some fixes require changes to the definitions, other require changes to the code itself.

The fake() test works as expected I just improved/narrowed the check.

@ST-DDT ST-DDT added c: bug Something isn't working c: test labels Mar 10, 2022
@ST-DDT ST-DDT added this to the v6.1 - First bugfixes milestone Mar 10, 2022
@ST-DDT ST-DDT assigned ST-DDT and unassigned ST-DDT Mar 10, 2022
@ST-DDT ST-DDT changed the title test: fix all functional tests test: fix all_functional tests Mar 10, 2022
@Shinigami92 Shinigami92 added needs rebase There is a merge conflict p: 1-normal Nothing urgent labels Mar 15, 2022
@ST-DDT ST-DDT force-pushed the test/fix-all-functional-tests branch from 429a734 to ac8904d Compare March 21, 2022 19:35
@ST-DDT ST-DDT removed the needs rebase There is a merge conflict label Mar 21, 2022
@ST-DDT ST-DDT added p: 2-high Fix main branch and removed p: 1-normal Nothing urgent labels Mar 21, 2022
@ST-DDT ST-DDT force-pushed the test/fix-all-functional-tests branch from ac8904d to b2b7d57 Compare March 26, 2022 01:05
@ST-DDT ST-DDT requested a review from a team March 26, 2022 01:09
@ST-DDT ST-DDT marked this pull request as ready for review March 26, 2022 01:09
@ST-DDT ST-DDT requested a review from a team as a code owner March 26, 2022 01:09
@codecov
Copy link

codecov bot commented Mar 26, 2022

Codecov Report

Merging #609 (23c17ee) into main (814880b) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 23c17ee differs from pull request most recent head f029a7d. Consider uploading reports for the commit f029a7d to get more accurate results

@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1923     1923              
  Lines      176891   176887       -4     
  Branches      896      895       -1     
==========================================
- Hits       175735   175727       -8     
- Misses       1100     1104       +4     
  Partials       56       56              
Impacted Files Coverage Δ
src/finance.ts 99.30% <0.00%> (-0.70%) ⬇️
src/name.ts 99.69% <0.00%> (-0.31%) ⬇️
src/random.ts 99.44% <0.00%> (-0.01%) ⬇️
src/git.ts 100.00% <0.00%> (ø)
src/fake.ts 100.00% <0.00%> (ø)
src/lorem.ts 100.00% <0.00%> (ø)
src/system.ts 96.48% <0.00%> (+0.03%) ⬆️

@ST-DDT ST-DDT self-assigned this Mar 26, 2022
@ST-DDT ST-DDT force-pushed the test/fix-all-functional-tests branch from 1a62741 to 23c17ee Compare March 28, 2022 08:23
@ST-DDT ST-DDT requested review from Shinigami92 and a team March 28, 2022 08:29
@Shinigami92 Shinigami92 requested a review from a team March 28, 2022 10:31
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 28, 2022 16:45
@Shinigami92 Shinigami92 merged commit 9fad09a into main Mar 28, 2022
@Shinigami92 Shinigami92 deleted the test/fix-all-functional-tests branch March 28, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working c: test p: 2-high Fix main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants