Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: drop usage of fake for internal calls #703

Merged
merged 2 commits into from
Mar 28, 2022
Merged

refactor: drop usage of fake for internal calls #703

merged 2 commits into from
Mar 28, 2022

Conversation

pkuczynski
Copy link
Member

String templates would be faster, but also come with proper type checks and easier refactoring.

@pkuczynski pkuczynski requested a review from a team as a code owner March 28, 2022 14:37
@pkuczynski pkuczynski self-assigned this Mar 28, 2022
@pkuczynski pkuczynski added the c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs label Mar 28, 2022
@pkuczynski pkuczynski added this to the v6.1 - First bugfixes milestone Mar 28, 2022
@codecov
Copy link

codecov bot commented Mar 28, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@3e47440). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 1b0aeed differs from pull request most recent head ba66204. Consider uploading reports for the commit ba66204 to get more accurate results

@@           Coverage Diff           @@
##             main     #703   +/-   ##
=======================================
  Coverage        ?   99.34%           
=======================================
  Files           ?     1923           
  Lines           ?   176888           
  Branches        ?      896           
=======================================
  Hits            ?   175732           
  Misses          ?     1100           
  Partials        ?       56
Impacted Files Coverage Δ
src/git.ts 100.00% <100.00%> (ø)
src/lorem.ts 100.00% <100.00%> (ø)
src/random.ts 99.44% <100.00%> (ø)
src/system.ts 96.44% <100.00%> (ø)

@ST-DDT ST-DDT requested review from a team March 28, 2022 14:50
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Mar 28, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 28, 2022 16:35
@Shinigami92 Shinigami92 changed the title feat: drop usage of fake for internal calls refactor: drop usage of fake for internal calls Mar 28, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 28, 2022 16:35
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 28, 2022 16:35
@Shinigami92 Shinigami92 merged commit 814880b into faker-js:main Mar 28, 2022
@pkuczynski pkuczynski deleted the drop-fake-internally branch March 28, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@import-brain import-brain import-brain approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@pkuczynski pkuczynski

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v6.1 - First bugfixes
Development

Successfully merging this pull request may close these issues.
5 participants
@pkuczynski @ST-DDT @Shinigami92 @import-brain @xDivisionByZerox