test: migrate datatype to test snapshots

[ST-DDT]

We should migrate from our old inline seeded tests to using test snapshots, as these are way easier to update.
I plan to update the other modules as well, but this one is the first in case something needs to be changed.

[codecov]

Codecov Report

Merging #875 (922b287) into main (ab2ed23) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
- Coverage   99.64%   99.64%   -0.01%     
==========================================
  Files        2146     2146              
  Lines      230380   230380              
  Branches      980      979       -1     
==========================================
- Hits       229571   229569       -2     
- Misses        788      790       +2     
  Partials       21       21              

Impacted Files	Coverage Δ
src/modules/internet/user-agent.ts	86.37% <0.00%> (-0.58%)	⬇️

[xDivisionByZerox]

I'm sorry but in what world is this easier to maintain? By changing any label in the entire test chain, you have an invalid expectation key.

Also since every snapshot value is a string, prettier can't apply the style guide correctly. Or am I missing something?

Can you please elaborate on how this helps maintainability wise?

[Shinigami92]

Snapshots can be updated by just using --update

But yeah, I was not aware that it just uses strings and therefore we loose the types 🤔
But maybe vitest uses some magic behind

[xDivisionByZerox]

Ok, I didn't know there was such an option. Thought the migration was done by hand.

[Shinigami92]

Ok, I didn't know there was such an option. Thought the migration was done by hand.

That's the whole point of using snapshots 😉

[Shinigami92]

I would prefer to have all tests migrated in one PR so it is only one commit in main branch history. You could create commits test by test to make review easier.

[ST-DDT]

All converted. Ready for review.