Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add examples and improve jsdocs for datatype.datetime #907

Merged
merged 1 commit into from
May 3, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented May 2, 2022

Discovered in #908

Preview (Click to expand)

grafik

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent labels May 2, 2022
@ST-DDT ST-DDT added this to the v7.0 - Next Minor milestone May 2, 2022
@ST-DDT ST-DDT requested review from a team May 2, 2022 23:48
@ST-DDT ST-DDT self-assigned this May 2, 2022
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #907 (80f5ecb) into main (a1685e1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #907      +/-   ##
==========================================
- Coverage   99.40%   99.40%   -0.01%     
==========================================
  Files        1959     1959              
  Lines      211067   211072       +5     
  Branches      910      909       -1     
==========================================
+ Hits       209821   209823       +2     
- Misses       1188     1191       +3     
  Partials       58       58              
Impacted Files Coverage Δ
src/datatype.ts 100.00% <100.00%> (ø)
src/finance.ts 99.31% <0.00%> (-0.69%) ⬇️

@Shinigami92 Shinigami92 requested a review from a team May 3, 2022 06:28
@ST-DDT ST-DDT merged commit 385c03a into main May 3, 2022
@ST-DDT ST-DDT deleted the feature/datatype/datetime-examples branch May 3, 2022 07:13
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label May 3, 2022
@xDivisionByZerox xDivisionByZerox added the m: datatype Something is referring to the datatype module label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior m: datatype Something is referring to the datatype module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants