Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove obsolete definition key constants #910

Merged
merged 1 commit into from
May 3, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented May 3, 2022

Since #822, we no longer need the internal definitions tree, so we should remove it.

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent labels May 3, 2022
@ST-DDT ST-DDT requested review from a team May 3, 2022 07:25
@ST-DDT ST-DDT self-assigned this May 3, 2022
@ST-DDT ST-DDT force-pushed the chore/remove-obsolete-definition-key-constants branch from 92452ab to 2910681 Compare May 3, 2022 07:25
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #910 (92452ab) into main (385c03a) will decrease coverage by 0.27%.
The diff coverage is 100.00%.

❗ Current head 92452ab differs from pull request most recent head 2910681. Consider uploading reports for the commit 2910681 to get more accurate results

@@            Coverage Diff             @@
##             main     #910      +/-   ##
==========================================
- Coverage   99.40%   99.13%   -0.28%     
==========================================
  Files        1959     1958       -1     
  Lines      211072   210788     -284     
  Branches      909      906       -3     
==========================================
- Hits       209823   208968     -855     
- Misses       1191     1744     +553     
- Partials       58       76      +18     
Impacted Files Coverage Δ
src/definitions/address.ts 0.00% <ø> (-100.00%) ⬇️
src/definitions/animal.ts 0.00% <ø> (-100.00%) ⬇️
src/definitions/commerce.ts 0.00% <ø> (-100.00%) ⬇️
src/definitions/company.ts 0.00% <ø> (-100.00%) ⬇️
src/definitions/database.ts 0.00% <ø> (-100.00%) ⬇️
src/definitions/date.ts 0.00% <ø> (-100.00%) ⬇️
src/definitions/definitions.ts 0.00% <ø> (-100.00%) ⬇️
src/definitions/finance.ts 0.00% <ø> (-100.00%) ⬇️
src/definitions/hacker.ts 0.00% <ø> (-100.00%) ⬇️
src/definitions/index.ts 0.00% <ø> (-100.00%) ⬇️
... and 27 more

@ST-DDT ST-DDT requested a review from a team May 3, 2022 07:53
@ST-DDT ST-DDT merged commit cc46a0c into main May 3, 2022
@ST-DDT ST-DDT deleted the chore/remove-obsolete-definition-key-constants branch May 3, 2022 08:58
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label May 3, 2022
@Shinigami92
Copy link
Member

While working on # 909, I run pnpm run generate:locales and it throwed errors at me unrelated to # 909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants