Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby-head failing due to timecop issue #2260

Closed
connorshea opened this issue Feb 9, 2021 · 5 comments · Fixed by #2262
Closed

ruby-head failing due to timecop issue #2260

connorshea opened this issue Feb 9, 2021 · 5 comments · Fixed by #2262
Labels
Chores 🐞 Issue: Bug

Comments

@connorshea
Copy link
Member

Describe the bug

It will presumably be fixed by this PR: travisjeffery/timecop#279

To Reproduce

View CI for ruby-head https://github.com/faker-ruby/faker/runs/1852774269

Expected behavior

No failure should happen on ruby-head
@psibi
Copy link
Member

psibi commented Feb 9, 2021

Probably failing on head shouldn't make the entire CI fail since HEAD changes frequently. It would be nice to have something like allowed_failures of Travis in github actions to make sure things aren't blocked because of it.

koic added a commit to koic/faker that referenced this issue Feb 9, 2021
@koic
Workaround build error for ruby-head
ee6a288 
Workaround for faker-ruby#2260.

This PR suspends ruby-head CI until travisjeffery/timecop#279 is resolved.

GitHub Actions doesn't seem to have a mechanism like Travis CI's allow-failure yet.
https://github.com/actions/toolkit/issues/399
@koic koic mentioned this issue Feb 9, 2021
Merged
@koic
Copy link
Member

koic commented Feb 9, 2021

I've opened #2262 that temporarily suspends the CI of ruby-head.

koic added a commit to koic/faker that referenced this issue Feb 9, 2021
@koic
Workaround build error for ruby-head
ae16563 
Workaround for faker-ruby#2260.

This PR suspends ruby-head CI until travisjeffery/timecop#279 is resolved.

GitHub Actions doesn't seem to have a mechanism like Travis CI's `allow_failures` yet.
https://github.com/actions/toolkit/issues/399
koic added a commit to koic/faker that referenced this issue Feb 9, 2021
@koic
Workaround build error for ruby-head
3b4cd79 
Fixes faker-ruby#2260.

This PR suspends ruby-head CI until travisjeffery/timecop#279 is resolved.

GitHub Actions doesn't seem to have a mechanism like Travis CI's `allow_failures` yet.
https://github.com/actions/toolkit/issues/399
@koic koic closed this as completed in #2262 Feb 9, 2021
@connorshea
Copy link
Member Author

thanks @koic!

@koic
Copy link
Member

koic commented Feb 9, 2021

You are welcome @connorshea!

@jwillemsen
Copy link

FYI, ruby-head works again with timecop

fcolacilli pushed a commit to fcolacilli/faker that referenced this issue Feb 11, 2021
@koic @fcolacilli
Workaround build error for ruby-head
c8eb77e 
Fixes faker-ruby#2260.

This PR suspends ruby-head CI until travisjeffery/timecop#279 is resolved.

GitHub Actions doesn't seem to have a mechanism like Travis CI's `allow_failures` yet.
https://github.com/actions/toolkit/issues/399
koic added a commit that referenced this issue Jan 8, 2022
@koic
CI against Ruby 3.2.0-dev
deb2a78 
#2260 was resolved and ruby-head is already Ruby 3.2.0-dev now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Chores 🐞 Issue: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Workaround build error for ruby-head koic/faker
4 participants
@koic @jwillemsen @psibi @connorshea