Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version to 2.12.0 #2027

Merged
merged 10 commits into from
May 31, 2020
Merged

Bump version to 2.12.0 #2027

merged 10 commits into from
May 31, 2020

Conversation

vbrazo
Copy link
Member

@vbrazo vbrazo commented May 31, 2020 •
edited
Loading

This PR bumps Faker to 2.12.0 and also:

  • adds several YARD docs
  • fixes some locale issues
  • fixes a few bugs in Faker generators
  • improves code quality
  • adds a few generators for Movies, Music and TV Shows
  • updates local dependencies

Kudos to @danielTiringer for all the YARD docs contributions.

@vbrazo vbrazo changed the title Bump version to 2 12 0 Bump version to 2.12.0 May 31, 2020
@vbrazo vbrazo self-assigned this May 31, 2020
@vbrazo vbrazo requested a review from a team May 31, 2020 18:40
connorshea
connorshea approved these changes May 31, 2020
View reviewed changes
Copy link
Member

@connorshea connorshea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some small changes, but otherwise LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
vbrazo and others added 5 commits May 31, 2020 11:50
@vbrazo
PRs
7c644d3
@vbrazo @connorshea
Update CHANGELOG.md
fdd93ba 
Co-authored-by: Connor Shea <connor.james.shea@gmail.com>
@vbrazo @connorshea
Update CHANGELOG.md
f1d2f49 
Co-authored-by: Connor Shea <connor.james.shea@gmail.com>
@vbrazo
fixes
e442f32
@vbrazo
Merge branch 'bump-version-to-2-12-0' of github.com:faker-ruby/faker …
01d6499 
…into bump-version-to-2-12-0
@vbrazo vbrazo merged commit 8c4015c into master May 31, 2020
@vbrazo vbrazo deleted the bump-version-to-2-12-0 branch May 31, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorshea connorshea connorshea approved these changes

Assignees

@vbrazo vbrazo

Labels
📘 Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbrazo @connorshea