Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix italy VAT and add italy condominium fiscal code generator #2491

Merged
merged 3 commits into from
Aug 19, 2022
Merged

fix italy VAT and add italy condominium fiscal code generator #2491

merged 3 commits into from
Aug 19, 2022

Conversation

FiloSpaTeam
Copy link
Contributor

Issue#

No-Story

Description:

Fixing Italy VAT to 11 digits and add new generator for italian condominium fiscal code.

vbrazo
vbrazo reviewed Jun 4, 2022
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rebase this PR with our main branch?

@FiloSpaTeam
Copy link
Contributor Author

Could you please rebase this PR with our main branch?

Now should be alright :) please give a check

saiqulhaq
saiqulhaq suggested changes Jul 3, 2022
View reviewed changes
Copy link

@saiqulhaq saiqulhaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to rebase with master to have this commit 594c055
so the Github action will pass

@Zeragamba Zeragamba assigned vbrazo and Zeragamba and unassigned vbrazo and Zeragamba Aug 8, 2022
Zeragamba
Zeragamba suggested changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@Zeragamba Zeragamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs to be rebased onto master to include testing pipeline

lib/faker/default/finance.rb Show resolved Hide resolved
@Zeragamba Zeragamba self-assigned this Aug 8, 2022
@Zeragamba Zeragamba merged commit d58c070 into faker-ruby:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo left review comments

@saiqulhaq saiqulhaq saiqulhaq requested changes

@Zeragamba Zeragamba Zeragamba approved these changes

Assignees

@Zeragamba Zeragamba

Labels
🐞 PR: Bugfix 🏃🏽 PR: In Progress 🙏🏽 PR: Needs Further Updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FiloSpaTeam @saiqulhaq @vbrazo @Zeragamba @stefannibrasil