Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zh-CN translations for Bank names #2840

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Add zh-CN translations for Bank names #2840

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed0ffab
add china bank name
guxiaobai Oct 16, 2023
73653d1
use dashes instead of an array
guxiaobai Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/locales/zh-CN/bank.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@

# Ref: https://pay.weixin.qq.com/docs/merchant/development/chart/bank-of-deposit.html

zh-CN:
faker:
bank:
name: ['工商银行', '交通银行', '招商银行', '民生银行', '浦发银行', '兴业银行', '光大银行', '广发银行', '平安银行', '建设银行', '邮政储蓄银行']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we prefer to use the dash syntax for lists of elements, see documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I've repaired it