Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: automatically do multi-part upload on 90+ MB files #111

Merged
merged 8 commits into from
Nov 26, 2024
Merged

feat: automatically do multi-part upload on 90+ MB files #111

merged 8 commits into from
Nov 26, 2024

Conversation

chamini2
Copy link
Member

@chamini2 chamini2 commented Nov 25, 2024 •
edited
Loading

image

@chamini2 chamini2 requested a review from drochetti November 25, 2024 21:22
chamini2
chamini2 commented Nov 25, 2024
View reviewed changes
libs/client/package.json Outdated Show resolved Hide resolved
drochetti
drochetti reviewed Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@drochetti drochetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this, unlocking large file sizeeees 🚀

I left a few minor comments, other than the async-sema we discussed offline. Everything else lgtm!

libs/client/src/storage.ts Outdated Show resolved Hide resolved
libs/client/src/storage.ts Outdated Show resolved Hide resolved
libs/client/src/storage.ts Outdated Show resolved Hide resolved
libs/client/src/storage.ts Outdated Show resolved Hide resolved
libs/client/src/storage.ts Show resolved Hide resolved
@chamini2 chamini2 requested a review from drochetti November 25, 2024 23:56
@drochetti drochetti added this to the 1.2.0 milestone Nov 26, 2024
This was referenced Nov 26, 2024
Closed
Closed
@drochetti drochetti changed the base branch from matteo/cdn-v3-2 to main November 26, 2024 01:26
@drochetti drochetti merged commit 9170021 into main Nov 26, 2024
@drochetti drochetti deleted the matteo/cdn-v3-3 branch November 26, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drochetti drochetti drochetti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@chamini2 @drochetti