-
-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix TestClient to preserve raw URI #2159
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2159 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 62 62
Lines 6829 6830 +1
Branches 1098 1098
=========================================
+ Hits 6829 6830 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this fix 👍
(The proposed newsfragment is great in telling the story, but it could probably be made a bit more concise, and tell what actually was fixed; in any case we can circle back on the newsfragments later in a followup PR to make sure the whole changelog looks coherent.)
Thank you for merging. I did it primarily for myself :-) My API heavily relies on correct %2F handling. When will it be approximately released in the PyPI? |
* fix TestClient to preserve raw URI * add test and changelog
Summary of Changes
When following raw URL recipe based on
RAW_URI
, it breaks routing withTestClient
becauseTestClient
hard-codeRAW_URI
CGI variable to/
.Related Issues
#2157
Pull Request Checklist
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.
docs/
.docs/
.versionadded
,versionchanged
, ordeprecated
directives.docs/_newsfragments/
, with the file name format{issue_number}.{fragment_type}.rst
. (Runtowncrier --draft
to ensure it renders correctly.)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
PR template inspired by the attrs project.