Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds policyreport adapter helm config for falcosidekick #329

Closed
wants to merge 1 commit into from
Closed

adds policyreport adapter helm config for falcosidekick #329

wants to merge 1 commit into from

Conversation

mritunjaysharma394
Copy link

@mritunjaysharma394 mritunjaysharma394 commented May 12, 2022

Signed-off-by: Mritunjay Sharma mritunjaysharma394@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

What this PR does / why we need it:

This PR adds support for policy report adapter in falcosidekick which was made available in its latest release.
Link to PR that added support is falcosecurity/falcosidekick#256
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

@poiana poiana added kind/feature New feature or request dco-signoff: yes kind/chart-release Add this label when the chart version has been bumped area/falcosidekick-chart labels May 12, 2022
@poiana
Copy link
Contributor

poiana commented May 12, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mritunjaysharma394
To complete the pull request process, please assign kris-nova after the PR has been reviewed.
You can assign the PR to them by writing /assign @kris-nova in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from fntlnz and krisnova May 12, 2022 12:59
@poiana
Copy link
Contributor

poiana commented May 12, 2022

Welcome @mritunjaysharma394! It looks like this is your first PR to falcosecurity/charts 🎉

Signed-off-by: Mritunjay Sharma <mritunjaysharma394@gmail.com>
@mritunjaysharma394
Copy link
Author

Closing this PR to work with @Issif directly on #329

@mritunjaysharma394 mritunjaysharma394 deleted the addpolicyreport branch May 12, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/falcosidekick-chart dco-signoff: yes kind/chart-release Add this label when the chart version has been bumped kind/feature New feature or request size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants