chore(docker): fix master CI by using debian:buster with no backports repo for gcc8 builder #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… repo for builder gcc8. Debian-buster backports repo is no more present upstream. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
poiana
added
kind/bug
FedeDP
commented
Apr 19, 2024
| - 'docker/**' | ||
|
|
||
| build-images-dev: | ||
| needs: [build-test-dev,paths-filter] |
There was a problem hiding this comment.
reusable_build_push_images workflow needs to download the built driverkit (for the driverkit main image), so we need to depend on build-test-dev too.
FedeDP
commented
Apr 19, 2024
| uses: ./.github/workflows/reusable_build_push_images.yml | ||
| with: | ||
| arch: ${{ matrix.arch }} | ||
| push: false |
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
FedeDP
force-pushed
the
chore/use_debian_buster_no_backports
branch
from
eb58aec
to
69e4fb6
Compare
FedeDP
changed the title
FedeDP
commented
Apr 19, 2024
| @@ -18,18 +18,19 @@ jobs: | |||
| arch: ${{ matrix.arch }} | |||
|
|
|||
| push-images-master: | |||
| needs: build-test-master | |||
There was a problem hiding this comment.
Moved needs at the top of the jobs.
FedeDP
commented
Apr 19, 2024
| with: | ||
| arch: ${{ matrix.arch }} | ||
| push: true |
FedeDP
commented
Apr 19, 2024
| @@ -48,14 +53,20 @@ jobs: | |||
| uses: docker/setup-buildx-action@f95db51fddba0c2d1ec667646a06c2ce06100226 # v3.0.0 | |||
|
|
|||
| - name: Login to Docker Hub | |||
| if: inputs.push | |||
There was a problem hiding this comment.
No need to login if we are not going to push.
LucaGuerra
approved these changes
Apr 19, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Debian-buster backports repo is no more present upstream: https://github.com/falcosecurity/driverkit/actions/runs/8749618529/job/24013163670
Also, enable build-dev CI to test images build if
dockerfolder was updated.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: