Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Lint CI Check for Consistent Coding Practices #159

Open
GLVSKiriti opened this issue Mar 20, 2024 · 7 comments
Open

Implementing Lint CI Check for Consistent Coding Practices #159

GLVSKiriti opened this issue Mar 20, 2024 · 7 comments
Assignees
Labels
help wanted Extra attention is needed kind/feature

Comments

@GLVSKiriti
Copy link
Contributor

GLVSKiriti commented Mar 20, 2024

Motivation

Linting code is a fundamental practice for ensuring consistent coding standards within a project. Integrating a linting CI check into the development workflow is considered a best practice, especially as many open-source projects already adopt this approach.

Also some repositories of falco have incorporated lint CI checks falcosidekick and falcoctl.

Following same pattern, it's beneficial to set up golangci-lint as the linter for this repository as well

Feature

Alternatives

Additional context
@leogr @FedeDP Please provide your feedback I will start working on it!!

@GLVSKiriti
Copy link
Contributor Author

/assign

@poiana
Copy link

poiana commented Jun 18, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member

leogr commented Jun 20, 2024

/remove-lifecycle stale

@leogr
Copy link
Member

leogr commented Jun 20, 2024

Totally agree on this. It would also be nice to make this approach consistent across all Go projects under the Falcosecurity org.

@poiana
Copy link

poiana commented Sep 18, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member

leogr commented Sep 18, 2024

/remove-lifecycle stale
/help

@poiana
Copy link

poiana commented Sep 18, 2024

@leogr:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/remove-lifecycle stale
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@poiana poiana added help wanted Extra attention is needed and removed lifecycle/stale labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/feature
Projects
None yet
Development

No branches or pull requests

3 participants