Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the event-generator to reflect the recent ruleset split (stable, incubating, sandbox) #86

Closed
1 task done
leogr opened this issue Sep 12, 2023 · 12 comments
Closed
1 task done
Assignees
Milestone

Comments

@leogr
Copy link
Member

leogr commented Sep 12, 2023

Motivation

Because of the Rules Maturity Framework proposal.

Feature

  • Reflect rules' changes
  • Implement a way to select action groups stable, incubating, sandbox
  • Only enable stable ones by default

Alternatives

No compelling alternatives.

Additional context

I assume we don't want any more of those rules which are now deprecated.

Tasks

Preview Give feedback
  1. approved area/commands area/events area/pkg dco-signoff: yes kind/cleanup kind/documentation kind/feature lgtm size/XL
    FedeDP
@poiana
Copy link

poiana commented Dec 11, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member Author

leogr commented Dec 11, 2023

/remove-lifecycle stale

@leogr
Copy link
Member Author

leogr commented Dec 11, 2023

/assign

@leogr
Copy link
Member Author

leogr commented Jan 29, 2024

  • Only enable stable ones by default

This has been addressed by #90

@leogr
Copy link
Member Author

leogr commented Mar 26, 2024

  • Implement a way to select action groups stable, incubating, sandbox

Likely, the best way to implement this is to add tags to the actions (similarly to rules tags) and implement a feature that allows filtering by tags. cc @FedeDP wdyt?

@leogr leogr added this to the v0.12.0 milestone Mar 26, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Mar 26, 2024

I agree, seems like the simplest solution.

@poiana
Copy link

poiana commented Jun 24, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member Author

leogr commented Jun 24, 2024

/remove-lifecycle stale
cc @alacuku @GLVSKiriti

@poiana
Copy link

poiana commented Sep 22, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member Author

leogr commented Sep 23, 2024

/remove-lifecycle stale

@leogr
Copy link
Member Author

leogr commented Oct 2, 2024

This has been addressed expect for one point:

I mplement a way to select action groups stable, incubating, sandbox

I will open a separate issue for that.
/close

@poiana poiana closed this as completed Oct 2, 2024
@poiana
Copy link

poiana commented Oct 2, 2024

@leogr: Closing this issue.

In response to this:

This has been addressed expect for one point:

I mplement a way to select action groups stable, incubating, sandbox

I will open a separate issue for that.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants