Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an event for default rule "Container drift detected using chmod" #182

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

GLVSKiriti
Copy link
Contributor

@GLVSKiriti GLVSKiriti commented Mar 20, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area events

What this PR does / why we need it:
Added an event for default rule "Container drift detected using chmod" as mentioned here

Which issue(s) this PR fixes:

Fixes #181

Special notes for your reviewer:

Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correctly triggering the rule?

… the rule

Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
@GLVSKiriti GLVSKiriti force-pushed the ContainerDriftDetcted branch from f4bd5ad to 1a8a006 Compare April 4, 2024 09:04
@GLVSKiriti
Copy link
Contributor Author

Is this correctly triggering the rule?

@FedeDP I used alpine container here and just created a file and set executable permission via chmod is enough to trigger the rule

containerdrifictdetected

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Apr 4, 2024

LGTM label has been added.

Git tree hash: ac4a9a72c61204ce9fed133578d43e414db3a0ee

@poiana
Copy link

poiana commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, GLVSKiriti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Apr 4, 2024
@poiana poiana merged commit 2925790 into falcosecurity:main Apr 4, 2024
4 checks passed
@GLVSKiriti GLVSKiriti deleted the ContainerDriftDetcted branch April 4, 2024 09:20
@leogr leogr added this to the v0.12.0 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an event for default rule "Container Drift Detcted"
4 participants