Added an event for default rule "Launch Package Management Process In Container" #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
GLVSKiriti
force-pushed
the
LaunchPackageManagementProcessInContainer
branch
from
3426fbd to
ce4f14d
Compare
FedeDP
reviewed
Apr 3, 2024
| func LaunchPackageManagementProcessInContainer(h events.Helper) error { | ||
| // Make sure it runs in container and user.name != _apt | ||
| if h.InContainer() { | ||
| if os.Getenv("USER") == "_apt" { |
There was a problem hiding this comment.
Can you expand on the need for this change?
There was a problem hiding this comment.
in the rule conditions user.name != _apt.
Due to that I am ensuring in the code that user.name != _apt.
There was a problem hiding this comment.
Uh nice! Didn't know that :)
|
LGTM label has been added. Git tree hash: ce47eb860d3a0f5bf0bb158faaf9c9e6f904b58f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, GLVSKiriti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area events
What this PR does / why we need it:
Added an event for default rule "Launch Package Management Process In Container" as mentioned here
Which issue(s) this PR fixes:
Fixes #178
Special notes for your reviewer: