Blog post about Kubernetes Response Engine with Google Cloud Run - Part 6 #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issif
reviewed
Jun 7, 2021
content/en/blog/falcosidekick-reponse-engine-part-5-cloud-run.md
Outdated
Show resolved
Hide resolved
developer-guy
force-pushed
the
feature/kre-based-on-gke-and-cloud-run
branch
2 times, most recently
from
3b4e4b9 to
01705dc
Compare
radhikapc
suggested changes
Jun 17, 2021
content/en/blog/falcosidekick-reponse-engine-part-6-cloud-run.md
Outdated
Show resolved
Hide resolved
content/en/blog/falcosidekick-reponse-engine-part-6-cloud-run.md
Outdated
Show resolved
Hide resolved
content/en/blog/falcosidekick-reponse-engine-part-6-cloud-run.md
Outdated
Show resolved
Hide resolved
content/en/blog/falcosidekick-reponse-engine-part-6-cloud-run.md
Outdated
Show resolved
Hide resolved
content/en/blog/falcosidekick-reponse-engine-part-6-cloud-run.md
Outdated
Show resolved
Hide resolved
content/en/blog/falcosidekick-reponse-engine-part-6-cloud-run.md
Outdated
Show resolved
Hide resolved
content/en/blog/falcosidekick-reponse-engine-part-6-cloud-run.md
Outdated
Show resolved
Hide resolved
content/en/blog/falcosidekick-reponse-engine-part-6-cloud-run.md
Outdated
Show resolved
Hide resolved
content/en/blog/falcosidekick-reponse-engine-part-6-cloud-run.md
Outdated
Show resolved
Hide resolved
content/en/blog/falcosidekick-reponse-engine-part-6-cloud-run.md
Outdated
Show resolved
Hide resolved
developer-guy
changed the title
|
/lgtm |
danpop-chainguard
previously approved these changes
Jun 21, 2021
|
thank you so much for helping me to improve this blog post, I will add you as a co-author to the blog post @radhikapc 🙏 |
developer-guy
force-pushed
the
feature/kre-based-on-gke-and-cloud-run
branch
3 times, most recently
from
461fb67 to
8b430c8
Compare
radhikapc
suggested changes
Jun 21, 2021
content/en/blog/falcosidekick-reponse-engine-part-6-cloud-run.md
Outdated
Show resolved
Hide resolved
content/en/blog/falcosidekick-reponse-engine-part-6-cloud-run.md
Outdated
Show resolved
Hide resolved
content/en/blog/falcosidekick-reponse-engine-part-6-cloud-run.md
Outdated
Show resolved
Hide resolved
content/en/blog/falcosidekick-reponse-engine-part-6-cloud-run.md
Outdated
Show resolved
Hide resolved
content/en/blog/falcosidekick-reponse-engine-part-6-cloud-run.md
Outdated
Show resolved
Hide resolved
content/en/blog/falcosidekick-reponse-engine-part-6-cloud-run.md
Outdated
Show resolved
Hide resolved
content/en/blog/falcosidekick-reponse-engine-part-6-cloud-run.md
Outdated
Show resolved
Hide resolved
content/en/blog/falcosidekick-reponse-engine-part-6-cloud-run.md
Outdated
Show resolved
Hide resolved
developer-guy
force-pushed
the
feature/kre-based-on-gke-and-cloud-run
branch
from
8b430c8 to
8c64df9
Compare
|
Yesterday, Falcosidekick released a new version of its Chart and this release includes Google Cloud Run and Google Cloud Functions features, so I think we are ready to merge both PR's #446 and #453 now if everything is okay. WDYT @radhikapc @Issif @Dentrax? |
|
I think we can publish both at the same time when we're ready. If both of OK for you, we'll need to update the dates, but pushing a new commit removes the LGTM label. |
developer-guy
force-pushed
the
feature/kre-based-on-gke-and-cloud-run
branch
from
8c64df9 to
8357654
Compare
developer-guy
changed the title
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com> Co-Authored-by: Radhika Puthiyetath <radhika.dwaraka@gmail.com>
developer-guy
force-pushed
the
feature/kre-based-on-gke-and-cloud-run
branch
from
8357654 to
5e74a77
Compare
danpop-chainguard
approved these changes
Jun 25, 2021
|
LGTM label has been added. Git tree hash: f87fbe8e9fa0d8786c8c8113e1560dc5c87aeec8
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danpopSD, developer-guy, radhikapc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com
What type of PR is this?
Any specific area of the project related to this PR?
What this PR does / why we need it:
This is another part of the Kubernetes Response Engine series, this time we are using Cloud Run to set up it.
Which issue(s) this PR fixes:
Fixes #444
Special notes for your reviewer:
We have to wait for
falcosecurity/chartsrepository to release Google Cloud Run support first.There is a PR already opened for adding it.