Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RelWithDebInfo build #2268

Closed
happy-dude opened this issue Oct 19, 2022 · 20 comments · May be fixed by #3440
Closed

RelWithDebInfo build #2268

happy-dude opened this issue Oct 19, 2022 · 20 comments · May be fixed by #3440

Comments

@happy-dude
Copy link
Contributor

Motivation

Hey team, I realize that Falco has only "Debug" and "Release" build types.
My team and org were wondering if it was possible to enable a RelWithDebInfo build?

RelWithDebInfo builds are usually built with all the performance optimizations of the release build, but with debug symbols turned on. This might be possible with CPACK_STRIP_FILES=Off and build type release, but I'm otherwise unfamiliar with the available cmake/cpack build options.

Feature

RelWithDebInfo build type; release-optimized, but with debug symbols

Alternatives

Possibly CPACK_STRIP_FILES=Off ? I need to investigate further if this satisfies the requirements of my team.

Additional context

https://cmake.org/cmake/help/latest/manual/cmake-buildsystem.7.html#default-and-custom-configurations
^ Does this imply that cmake supports RelWithDebInfo by default and will compile + build accordingly?

@jasondellaluce
Copy link
Contributor

/milestone 0.34.0

@poiana poiana added this to the 0.34.0 milestone Oct 20, 2022
@leogr leogr moved this to 🆕 New in Falco Roadmap Nov 30, 2022
@jasondellaluce
Copy link
Contributor

/milestone 0.35.0

@poiana
Copy link
Contributor

poiana commented Apr 10, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@Andreagit97
Copy link
Member

/remove-lifecycle stale

@FedeDP
Copy link
Contributor

FedeDP commented May 18, 2023

Moving to next milestone unless someone wants to tackle this! (in case feel free to move it back to 0.35!) :)
/milestone 0.36.0

@poiana poiana modified the milestones: 0.35.0, 0.36.0 May 18, 2023
@poiana
Copy link
Contributor

poiana commented Aug 16, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor

FedeDP commented Aug 23, 2023

/remove-lifecycle stale

@Andreagit97 Andreagit97 modified the milestones: 0.36.0, TBD Aug 31, 2023
@poiana
Copy link
Contributor

poiana commented Nov 29, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@Andreagit97
Copy link
Member

/remove-lifecycle stale

@poiana
Copy link
Contributor

poiana commented Feb 28, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor

FedeDP commented Feb 29, 2024

/remove-lifecycle stale

@poiana
Copy link
Contributor

poiana commented May 29, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@Andreagit97
Copy link
Member

/remove-lifecycle stale

@poiana
Copy link
Contributor

poiana commented Aug 27, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@poiana
Copy link
Contributor

poiana commented Sep 26, 2024

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@poiana
Copy link
Contributor

poiana commented Oct 26, 2024

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana poiana closed this as completed Oct 26, 2024
@poiana
Copy link
Contributor

poiana commented Oct 26, 2024

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@shane-lawrence
Copy link
Contributor

I'm trying to debug segfaults on under particular circumstances on very busy nodes and having the debug symbols for a release binary would be very helpful!

@shane-lawrence
Copy link
Contributor

/reopen

@poiana
Copy link
Contributor

poiana commented Dec 23, 2024

@shane-lawrence: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants