fetch libs and drivers from the new repo #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leogr
force-pushed
the
update/lib-migration
branch
from
f6f1418 to
18c9ea5
Compare
leogr
force-pushed
the
update/lib-migration
branch
from
18c9ea5 to
3eddbee
Compare
poiana
added
size/L
release-note
and removed
size/M
do-not-merge/release-note-label-needed
labels
fntlnz
previously approved these changes
Apr 7, 2021
|
LGTM label has been added. Git tree hash: 7188d45510f0f9133c3b235bedd844a827675c77
|
|
/milestone 0.28.1 |
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
The option was added but could not work since MINIMAL_BUILD is not declared in this scope (also not currently needed). Furthermore, it never took effect since the builder image was never built and pushed. For the same reason, we have not noticed it until now. Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
…417273275296813066e07cb85bc91 Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
leogr
force-pushed
the
update/lib-migration
branch
from
67f0c94 to
281dd86
Compare
leogr
changed the title
|
All required PRs are now merged into It's now ready to be reviewed again. Thank you! |
mstemm
approved these changes
May 20, 2021
|
LGTM label has been added. Git tree hash: c23f0a9a7665c5bdd0b23f535ad4f915ed6b03ab
|
leodido
reviewed
May 20, 2021
| @@ -48,7 +48,7 @@ set(CPACK_DEBIAN_PACKAGE_CONTROL_EXTRA | |||
| set(CPACK_RPM_PACKAGE_LICENSE "Apache v2.0") | |||
| set(CPACK_RPM_PACKAGE_ARCHITECTURE, "amd64") | |||
| set(CPACK_RPM_PACKAGE_URL "https://www.falco.org") | |||
| set(CPACK_RPM_PACKAGE_REQUIRES "dkms, kernel-devel, ncurses, systemd") | |||
| set(CPACK_RPM_PACKAGE_REQUIRES "dkms, kernel-devel, systemd") | |||
There was a problem hiding this comment.
btw, I left further ncurses cleanups for later #1638
🥳
leodido
approved these changes
May 21, 2021
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
As per this proposal, the repo falcosecurity/libs is the new home for libscap, sinsp, and drivers.
This PR updates the building system to point to the new location and also update the driver version to
13ec67ebd23417273275296813066e07cb85bc91.Finally, it introduces necessary adaptations and improvements to make the Falco building system work with changes recently introduced in falcosecurity/libs cmakefiles (in particular by falcosecurity/libs#23 and falcosecurity/libs#30)
TODOs:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
N.B.
Release note has been set to
NONEsince13ec67has not been published.The correct changelog line is set by #1669