build: always populate partial version variables #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When FALCO_VERSION was provided via a CMake variable, the build would eventually fail because the partial version variables hadn't been populated. Move the creation of those outside the check of FALCO_VERSION being set so they also happen when that is provided too. Contributes-to: falcosecurity#1654 Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
dnwe
force-pushed
the
fix-falco-version
branch
from
c890f6e to
e77c92d
Compare
|
Thanks for the fix! This seems to work for me! Since this seems to fix #1654, can you add this to the PR description? That would help closing the issue automatically once this gets merged. |
|
@jasondellaluce sure. I originally put it just as Contributes-to as I was waiting for the OP to confirm it worked for them too. Have updated to Fixes now I’ve had another confirm though. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dnwe, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 5d9b65d6fb2cb00d0976b094f1e18e88a5e62c93
|
mstemm
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
When FALCO_VERSION was provided via a CMake variable, the build would
eventually fail because the partial version variables hadn't been
populated. Move the creation of those outside the check of FALCO_VERSION
being set so they also happen when that is provided too.
Which issue(s) this PR fixes:
Fixes: #1654
Special notes for your reviewer:
Does this PR introduce a user-facing change?: