Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused files in test directory #1801

Merged

Conversation

jasondellaluce
Copy link
Contributor

Signed-off-by: Jason Dellaluce jasondellaluce@gmail.com

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area tests

What this PR does / why we need it:

This cleans up the test directory by removing some legacy scripts that seem to not be used anymore by Falco.

  • run_performance_tests.sh
  • plot-live.r
  • plot-traces.r
  • cpu_monitor.sh

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

/milestone 0.31.0
/approve

Copy link
Contributor

@mstemm mstemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks--I originally added them a long long time ago when we were doing a round of falco performance testing. They're potentially useful if we want to do another round of performance testing, but I'm fine with removing them from the tree for now.

@poiana
Copy link
Contributor

poiana commented Dec 6, 2021

LGTM label has been added.

Git tree hash: 15b25ee9c26b7e3c1adc38b9ff20c81683df39dc

@leogr
Copy link
Member

leogr commented Dec 9, 2021

/milestone 0.31.0

@poiana poiana added this to the 0.31.0 milestone Dec 9, 2021
@leogr
Copy link
Member

leogr commented Dec 9, 2021

/approve

@poiana
Copy link
Contributor

poiana commented Dec 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Dec 9, 2021
@poiana poiana merged commit b5667ca into falcosecurity:master Dec 9, 2021
@jasondellaluce jasondellaluce deleted the refactor/clean-test-folder branch December 10, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants