Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(build)!: replaced various PROBE with DRIVER where necessary. #1887

Merged

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Feb 3, 2022

Follow-up of falcosecurity/libs#197.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana poiana requested review from fntlnz and mstemm February 3, 2022 11:13
@poiana poiana added the size/M label Feb 3, 2022
@FedeDP FedeDP force-pushed the refactor/replace-probe-with-driver branch 2 times, most recently from 22ebbcb to 8a981c9 Compare February 5, 2022 11:26
@FedeDP FedeDP changed the title wip: update(build)!: replaced various PROBE with DRIVER where necessary. update(build)!: replaced various PROBE with DRIVER where necessary. Feb 5, 2022
@FedeDP FedeDP closed this Feb 7, 2022
@FedeDP FedeDP reopened this Feb 7, 2022
@FedeDP
Copy link
Contributor Author

FedeDP commented Feb 7, 2022

Reopened to trigger CI.

@FedeDP
Copy link
Contributor Author

FedeDP commented Feb 7, 2022

Waiting on falcosecurity/libs#199 to get merged on libs, then rebasing this one on top of new libs master.

@FedeDP FedeDP changed the title update(build)!: replaced various PROBE with DRIVER where necessary. wip: update(build)!: replaced various PROBE with DRIVER where necessary. Feb 7, 2022
Follow-up of falcosecurity/libs#197.
Updated libs too to master version, as needed.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP FedeDP force-pushed the refactor/replace-probe-with-driver branch from 34ba096 to dc0bf6f Compare February 7, 2022 16:37
@FedeDP FedeDP changed the title wip: update(build)!: replaced various PROBE with DRIVER where necessary. update(build)!: replaced various PROBE with DRIVER where necessary. Feb 7, 2022
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@FedeDP Thank you 🙏

/approve

@poiana poiana added the lgtm label Feb 8, 2022
@poiana
Copy link
Contributor

poiana commented Feb 8, 2022

LGTM label has been added.

Git tree hash: 1673b52e27727a122b4e9101d6bad789ef2baddc

@poiana poiana added the approved label Feb 8, 2022
@leogr
Copy link
Member

leogr commented Feb 8, 2022

/milestone 0.32.0

@poiana poiana added this to the 0.32.0 milestone Feb 8, 2022
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Feb 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit ff21544 into falcosecurity:master Feb 8, 2022
@FedeDP FedeDP deleted the refactor/replace-probe-with-driver branch February 8, 2022 08:52
@jasondellaluce jasondellaluce modified the milestones: 0.32.0, 0.31.1 Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants