Support multi-architecture(arm64) build #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @nickytd! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
Signed-off-by: Niki Dokovski <nickytd@gmail.com>
nickytd
force-pushed
the
enable-platform-arch-in-build
branch
from
bc21a98
to
e860a9b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, nickytd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 902c649086f1fedc25ab57cd3e587e5791f32e2f
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind feature
/area build
This PR uses GOARCH environment variable in Makefile also in the falcosidekick container image binary build. It supports builds on arm64 architecture in addition to the amd64.
In addition it add build flags to the container image as well.
Example:
docker run --rm docker.io/falcosecurity/falcosidekick:latest --version GitVersion: 2.29.0-71-g0f39f47-dirty GitCommit: 0f39f47e11721722a0993690ad472887e17085a7 GitTreeState: dirty BuildDate: '2024-10-15T07:59:36Z' GoVersion: go1.23.2 Compiler: gc Platform: linux/arm64